Summary

I created a new proofgen binary writes all of the test cases into json files. The verify_go tests have been updated to walk the file tree and use each json file as input.

Thought Process

Every json file contains a wantErr flag to communicate to the consumer that this input should result in an error. Similarly, every input contains a desc field that describes what the test is attempting to validate. These two concepts were inconsistently used in the previous test suite so in an effort in standardize the json schema I adopted it everywhere.

Because the "desc" field is new to many of these tests, I had to do a bit of reverse engineering to figure out what each test input was trying to test. I'd encourage the reviewers here to validate that these additions are accurate. An example of this can be found in writeStaticConsistencyTestData. On that note, you'll notice some of these new descriptions are repetitive, because the test cases themselves are repetitive. I'd be happy to remove some of that repetition but I figured I'd defer to the maintainers before doing so.

A general issue with the test data that I believe some consumers may struggle with: a lot of these tests are (rightfully) designed for this specific implementation. Depending on the order in which a consumer performs these checks themselves, they may receive false negatives.

Lastly, a general note: I am not a Go developer, so feel free to suggest improvements wherever you see them 😄

Additional Changes

The first commit here removes a test case that was never referenced. The only reference to inclusionProofs skipped the first index because it was invalid.

Related Issue

Resolves: #169

Testing instructions

1. Delete the testdata directory
2. Run proofgen: go run ./cmd/proofgen
3. Run tests in proof directory